Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a semi-big whistle cooldown. #5469

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

ClairionCM
Copy link
Contributor

@ClairionCM ClairionCM commented Jan 16, 2024

Adds a 10 second cooldown to the whistles to make them less spammy

About the pull request

This PR gives the whistles a 10 second cooldown to have people spam them less. It also sends a message telling the player how long they need to wait before they can use it again.

Explain why it's good for the game

Right now what often ends up happening is people deleting all of the whistles because they are VERY loud and VERY spammy. This should make that less of an issue.

Testing Photographs and Procedure

It works :D

image

Changelog

🆑
qol: made whistles less spammy
/:cl:

Adds a 10 second cooldown to the whistles to make them less spammy
@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jan 16, 2024
@BroseidonMOO BroseidonMOO added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jan 16, 2024
code/game/objects/items/devices/whistle.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine.

@Antixenobuff

This comment was marked as off-topic.

@Wintermote

This comment was marked as off-topic.

@Birdtalon Birdtalon mentioned this pull request Jan 16, 2024
3 tasks
@Bagpepos Bagpepos mentioned this pull request Jan 17, 2024
3 tasks
@gitbirb
Copy link

gitbirb commented Jan 17, 2024

maybe Make sure the cooldowns are for all whistles on a person and not individual whistles.
People can currently carry like 2 or 3 whistles to circumvent cooldown... thats often used to spam whistles like crazy.

@ClairionCM
Copy link
Contributor Author

Yeah I know the cooldown being on the item is weird and I'll try to fix it when I manage to figure it out. I'm really bad at coding and also really busy most of the time so that might take a while.
But yeah I00% agree that it should be tied to the mob instead of the whistle object. The issue has basically been solved since now its really impractical to spam whistles but I should fix it even if its just to clean up the code a bit more.

@Drulikar Drulikar added this pull request to the merge queue Jan 20, 2024
Merged via the queue into cmss13-devs:master with commit a34b1c3 Jan 20, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants